Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1051023004: Compute IS_CLIENT result. (Closed)

Created:
5 years, 8 months ago by scheglov
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Compute IS_CLIENT result. It is easy now with import source closure. So, we can remove the temporary HAS_HTML_IMPORT result. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -28 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/task/dart.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +38 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 8 months ago (2015-04-06 17:26:20 UTC) #1
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-04-06 17:30:38 UTC) #2
scheglov
5 years, 8 months ago (2015-04-06 17:32:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44919 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698