Issue 1050983002: Tweaks for hover - local variables and methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1050983002: Tweaks for hover - local variables and methods. (Closed)

Created:
5 years, 8 months ago by scheglov

Modified:
5 years, 8 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Tweaks for hover - local variables and methods. 1. We don't need enclosing class and library for local elements. 2. None of the elements other than methods append class name in toString(), so remove it there too. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44838

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -17 lines)			Patch
M	pkg/analysis_server/lib/src/computer/computer_hover.dart	View	1 chunk	+14 lines, -11 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/get_hover_test.dart	View	4 chunks	+30 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 (id:1) manually as 44838 (presubmit successful).

5 years, 8 months ago (2015-04-01 18:24:26 UTC) #3

Paul Berry

5 years, 8 months ago (2015-04-02 16:24:55 UTC) #4

Message was sent while issue was closed.

On 2015/04/01 18:24:26, scheglov wrote:
> Committed patchset #1 (id:1) manually as 44838 (presubmit successful).

It looks like this CL broke the integration test "get_hover_test".  Repro:

python tools/test.py --checked -mrelease -t60
pkg/analysis_server/test/integration/analysis/get_hover_test

(Unfortunately the pub-pkg buildbots have been broken for the last few days so
they weren't able to detect this failure).

Expand Messages | Collapse Messages