Issue 1050823006: Add utility function for getting increasing numbers in a git only world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1050823006: Add utility function for getting increasing numbers in a git only world. (Closed)

Created:
5 years, 8 months ago by ricow1

Modified:
5 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Add utility function for getting increasing numbers in a git only world. The numbers will be used for archiving purposes, so that we have a standard way of calculating a location, that will sort in increasing order of commits. For dev/stable channel builds we will move to use the version number instead. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45327

Patch Set 1 #

Patch Set 2 : Add function for getting the archive "location" #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
	M	tools/utils.py	View	1	1 chunk	+34 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/1050823006/diff/20001/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/1050823006/diff/20001/tools/utils.py#newcode429 tools/utils.py:429: GIT_NUMBER_BASE = 100000 When we have the GitHub ...

5 years, 8 months ago (2015-04-21 13:04:30 UTC) #2

ricow1

5 years, 8 months ago (2015-04-22 04:01:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 45327 (presubmit successful).

Expand Messages | Collapse Messages