Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1050133006: Add structural equality to ConstantExpression. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add structural equality to ConstantExpression. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45344

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -54 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 5 chunks +14 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 16 chunks +334 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 2 chunks +19 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +75 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 8 months ago (2015-04-22 11:45:41 UTC) #2
karlklose
LGTM. I would prefer simple type checks over the tags, but that may actually be ...
5 years, 8 months ago (2015-04-22 12:02:19 UTC) #3
Johnni Winther
5 years, 8 months ago (2015-04-22 13:04:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45344 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698