Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1050083003: Fix compiler errors that seem to show up in the Android build under mojo/sky (Closed)

Created:
5 years, 8 months ago by siva
Modified:
5 years, 8 months ago
Reviewers:
koda
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix compiler errors that seem to show up in the Android build under mojo/sky ../../dart/runtime/vm/compiler.cc: In static member function 'static dart::RawError* dart::Compiler::Compile(const dart::Library&, const dart::Script&)': ../../dart/runtime/vm/compiler.cc:181:18: error: variable 'isolate' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered] Isolate* const isolate = Isolate::Current(); ^ ../../dart/runtime/vm/compiler.cc: In static member function 'static dart::RawObject* dart::Compiler::EvaluateStaticInitializer(const dart::Field&)': ../../dart/runtime/vm/compiler.cc:1145:18: error: variable 'isolate' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered] Isolate* const isolate = Isolate::Current(); ^ Committed: https://code.google.com/p/dart/source/detail?r=44850

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M runtime/vm/compiler.cc View 1 2 12 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
siva
5 years, 8 months ago (2015-04-01 21:35:33 UTC) #2
siva
5 years, 8 months ago (2015-04-01 23:11:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r44850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698