Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1049863002: Let debugger find async function literals (Closed)

Created:
5 years, 8 months ago by hausner
Modified:
5 years, 8 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Let debugger find async function literals This is a fix for issue 22030. When looking for known functions, consider even non-debuggable functions, so that we don’t set the breakpoint too eagerly in the outer function. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M runtime/vm/debugger.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hausner
5 years, 8 months ago (2015-04-01 00:02:38 UTC) #2
Ivan Posva
LGTM -ip
5 years, 8 months ago (2015-04-01 00:11:21 UTC) #4
hausner
Committed patchset #1 (id:1) manually as r44829 (presubmit successful).
5 years, 8 months ago (2015-04-01 00:18:16 UTC) #5
srdjan
5 years, 8 months ago (2015-04-01 16:36:52 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698