Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1049303002: Issue 19929. Record the propagated type into LHS of the assignment. (Closed)

Created:
5 years, 8 months ago by scheglov
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Issue 19929. Record the propagated type into LHS of the assignment. This is a fix only for https://code.google.com/p/dart/issues/detail?id=19929#c8 , not the whole issue. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=19929 Committed: https://code.google.com/p/dart/source/detail?r=44812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -67 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +46 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 22 chunks +27 lines, -60 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 8 months ago (2015-03-31 17:34:16 UTC) #1
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-03-31 18:10:22 UTC) #2
scheglov
5 years, 8 months ago (2015-03-31 18:22:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698