Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1049013002: Remove directives validation. (Closed)

Created:
5 years, 8 months ago by scheglov
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove directives validation. I was not able to get to this check, we stop analyzing before it. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -55 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +2 lines, -39 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 8 months ago (2015-03-30 21:37:21 UTC) #1
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-03-30 21:40:46 UTC) #2
scheglov
5 years, 8 months ago (2015-03-30 21:41:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44795 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698