Trace lists when they are stored into other lists.

Trace lists when they are stored into other lists.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30943

[kasperl, 2013-12-06 11:29:57]

LGTM.

https://codereview.chromium.org/104893007/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart
(right):

https://codereview.chromium.org/104893007/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:130:
Set<String> doesNotEscapeElementSet = new Set<String>.from(
Would it be possible to maintain this as annotations on the JSArray methods
long-term?

https://codereview.chromium.org/104893007/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:355:
bailout('Stored in too many containers');
Add a comment that explains why a null allocationNode means that it's stored in
too many containers.

[ngeoffray, 2013-12-06 11:36:25]

Thanks Kasper.

https://codereview.chromium.org/104893007/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart
(right):

https://codereview.chromium.org/104893007/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:130:
Set<String> doesNotEscapeElementSet = new Set<String>.from(
On 2013/12/06 11:29:57, kasperl wrote:
> Would it be possible to maintain this as annotations on the JSArray methods
> long-term?

For some yes, but how would you do it for methods on Object or Iterable? We
would need to explicitly call the super method.

https://codereview.chromium.org/104893007/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:355:
bailout('Stored in too many containers');
On 2013/12/06 11:29:57, kasperl wrote:
> Add a comment that explains why a null allocationNode means that it's stored
in
> too many containers.

Done.

[ngeoffray, 2013-12-06 11:37:10]

Committed patchset #2 manually as r30943 (presubmit successful).