Issue 1048463002: Issue 22279. Tweak constants evaluation error messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1048463002: Issue 22279. Tweak constants evaluation error messages. (Closed)

Created:
5 years, 9 months ago by scheglov

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Issue 22279. Tweak constants evaluation error messages. LMK if the new messages are also not good. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=22279 Committed: https://code.google.com/p/dart/source/detail?r=44772

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	pkg/analyzer/lib/src/generated/error.dart	View		4 chunks	+7 lines, -7 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1048463002/diff/1/pkg/analyzer/lib/src/generated/error.dart File pkg/analyzer/lib/src/generated/error.dart (right): https://codereview.chromium.org/1048463002/diff/1/pkg/analyzer/lib/src/generated/error.dart#newcode708 pkg/analyzer/lib/src/generated/error.dart:708: "In constant expressions operand(s) of this operator must ...

5 years, 9 months ago (2015-03-28 02:35:33 UTC) #2

scheglov

Committed patchset #1 (id:1) manually as 44772 (presubmit successful).

5 years, 9 months ago (2015-03-28 03:08:30 UTC) #3

scheglov

5 years, 9 months ago (2015-03-28 03:09:15 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1048463002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/1048463002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error.dart:708: "In constant expressions
operand(s) of this operator must be of type 'bool'");
On 2015/03/28 02:35:33, Brian Wilkerson wrote:
> I'd change "expressions" --> "expressions," but otherwise looks good.

Done.

Expand Messages | Collapse Messages