Issue 1047823006: Fix Dartium test breakage after r44802.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1047823006: Fix Dartium test breakage after r44802. (Closed)

Created:
5 years, 8 months ago by Paul Berry

Modified:
5 years, 8 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Fix Dartium test breakage after r44802. Compile-time errors apparently manifest in the Dartium tests as runtime errors, so the new "if_null" tests need to be marked as RuntimeError for Dartium. TBR=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=44803

Patch Set 1 #

Total comments: 2

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	tests/language/language.status	View		1 chunk	+7 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

Committed patchset #1 (id:1) manually as 44803 (presubmit successful).

5 years, 8 months ago (2015-03-31 14:13:27 UTC) #1

hausner

lgtm w/comment https://codereview.chromium.org/1047823006/diff/1/tests/language/language.status File tests/language/language.status (right): https://codereview.chromium.org/1047823006/diff/1/tests/language/language.status#newcode26 tests/language/language.status:26: [ $compiler == none && $runtime == ...

5 years, 8 months ago (2015-03-31 15:33:45 UTC) #2

Paul Berry

5 years, 8 months ago (2015-03-31 15:36:28 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/1047823006/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/1047823006/diff/1/tests/language/language.sta...
tests/language/language.status:26: [ $compiler == none && $runtime == dartium ]
On 2015/03/31 15:33:44, hausner wrote:
> Why not just mark them as Fail instead of the more specific annotations. There
> is no gain in being over-specific here. Keep it simple.

Good point.  I will fix in a follow-up CL.

Expand Messages | Collapse Messages