Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1047733004: Support refresh of individual analysis roots (issue 22254) (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support refresh of individual analysis roots (issue 22254) R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44791

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Total comments: 2

Patch Set 3 : Address more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -12 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RequestErrorCode.java View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 2 2 chunks +25 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 2 1 chunk +29 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 2 chunks +18 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 4 chunks +10 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/reanalyze_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 3 chunks +27 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Brian Wilkerson
5 years, 8 months ago (2015-03-30 19:29:37 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1047733004/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/1047733004/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode741 pkg/analysis_server/lib/src/analysis_server.dart:741: operationQueue.clear(); What is there were pending operations for ...
5 years, 8 months ago (2015-03-30 19:41:44 UTC) #3
Brian Wilkerson
PTAL https://codereview.chromium.org/1047733004/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/1047733004/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode741 pkg/analysis_server/lib/src/analysis_server.dart:741: operationQueue.clear(); Good catch!
5 years, 8 months ago (2015-03-30 20:33:38 UTC) #4
scheglov
https://codereview.chromium.org/1047733004/diff/20001/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/1047733004/diff/20001/pkg/analysis_server/lib/src/analysis_server.dart#newcode1112 pkg/analysis_server/lib/src/analysis_server.dart:1112: AnalysisContext context = getContainingContext(resource.path); There might be more that ...
5 years, 8 months ago (2015-03-30 20:38:07 UTC) #5
Brian Wilkerson
PTAL https://codereview.chromium.org/1047733004/diff/20001/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/1047733004/diff/20001/pkg/analysis_server/lib/src/analysis_server.dart#newcode1112 pkg/analysis_server/lib/src/analysis_server.dart:1112: AnalysisContext context = getContainingContext(resource.path); > There might be ...
5 years, 8 months ago (2015-03-30 21:01:25 UTC) #6
scheglov
LGTM
5 years, 8 months ago (2015-03-30 21:02:35 UTC) #7
Brian Wilkerson
5 years, 8 months ago (2015-03-30 21:07:36 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 44791 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698