Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1046993002: Support building Observatory in mojo tree (Closed)

Created:
5 years, 8 months ago by Cutch
Modified:
5 years, 8 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, ricow1, turnidge, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

- Split observatory source list into separate gypi file. - Update observatory_tool.py to support running against an SDK. BUG= R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=44794

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -147 lines) Patch
M runtime/observatory/observatory.gypi View 1 chunk +2 lines, -126 lines 0 comments Download
A runtime/observatory/observatory_sources.gypi View 1 chunk +142 lines, -0 lines 0 comments Download
M tools/observatory_tool.py View 1 2 2 chunks +56 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Cutch
5 years, 8 months ago (2015-03-30 19:40:55 UTC) #2
zra
https://codereview.chromium.org/1046993002/diff/1/runtime/observatory/BUILD.gn File runtime/observatory/BUILD.gn (right): https://codereview.chromium.org/1046993002/diff/1/runtime/observatory/BUILD.gn#newcode31 runtime/observatory/BUILD.gn:31: rebase_path("../../../third_party/dart-sdk/dart-sdk/bin/pub"), I think we generally don't want code in ...
5 years, 8 months ago (2015-03-30 19:50:03 UTC) #3
Cutch
https://codereview.chromium.org/1046993002/diff/1/runtime/observatory/BUILD.gn File runtime/observatory/BUILD.gn (right): https://codereview.chromium.org/1046993002/diff/1/runtime/observatory/BUILD.gn#newcode31 runtime/observatory/BUILD.gn:31: rebase_path("../../../third_party/dart-sdk/dart-sdk/bin/pub"), On 2015/03/30 19:50:03, zra wrote: > I think ...
5 years, 8 months ago (2015-03-30 20:16:38 UTC) #4
Cutch
PTAL
5 years, 8 months ago (2015-03-30 21:12:58 UTC) #5
zra
lgtm
5 years, 8 months ago (2015-03-30 21:14:24 UTC) #6
Cutch
5 years, 8 months ago (2015-03-30 21:21:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 44794 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698