Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1046573002: pkg/http_parser: format code, prepare for +6 release (Closed)

Created:
5 years, 8 months ago by kevmoo
Modified:
5 years, 8 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/http_parser.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : cl feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -62 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/bytes_builder.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M lib/src/http_date.dart View 3 chunks +18 lines, -20 lines 0 comments Download
M lib/src/media_type.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/media_type_test.dart View 5 chunks +13 lines, -22 lines 0 comments Download
M test/web_socket_test.dart View 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 8 months ago (2015-03-28 22:23:20 UTC) #2
nweiz
https://codereview.chromium.org/1046573002/diff/1/lib/src/web_socket.dart File lib/src/web_socket.dart (right): https://codereview.chromium.org/1046573002/diff/1/lib/src/web_socket.dart#newcode1 lib/src/web_socket.dart:1: // Copyright (c) 2014, the Dart project authors. Please ...
5 years, 8 months ago (2015-03-30 22:23:47 UTC) #3
kevmoo
https://codereview.chromium.org/1046573002/diff/1/lib/src/web_socket.dart File lib/src/web_socket.dart (right): https://codereview.chromium.org/1046573002/diff/1/lib/src/web_socket.dart#newcode1 lib/src/web_socket.dart:1: // Copyright (c) 2014, the Dart project authors. Please ...
5 years, 8 months ago (2015-03-30 22:42:36 UTC) #4
nweiz
lgtm
5 years, 8 months ago (2015-03-30 22:56:58 UTC) #5
kevmoo
5 years, 8 months ago (2015-03-30 22:58:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0fe3ed87beef1f17f8bd260bff39aa5104a3abef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698