Issue 104583002: Small cleanup and more test coverage for guarded fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 104583002: Small cleanup and more test coverage for guarded fields. (Closed)

Created:
7 years ago by Florian Schneider

Modified:
7 years ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Small cleanup and more test coverage for guarded fields. Some cases of field guards for guarded length were not covered by our tests. Otherwise I removed redundant conditions that are either impossible or always true from the code generator for GuardFieldInstr. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=30887

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -119 lines)			Patch
M	runtime/vm/intermediate_language_arm.cc	View	3 chunks	+22 lines, -30 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	3 chunks	+21 lines, -30 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	3 chunks	+22 lines, -29 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	3 chunks	+22 lines, -30 lines	0 comments	Download
M	tests/language/vm/optimized_guarded_field_test.dart	View	3 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

I'm in the process of simplifying the code for guarded fields. This is a first ...

7 years ago (2013-12-04 13:40:35 UTC) #1

Florian Schneider

7 years ago (2013-12-05 11:17:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30887 (presubmit successful).

Expand Messages | Collapse Messages