Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1045553002: Implement the new '??' operator in analyzer. (Closed)

Created:
5 years, 8 months ago by Paul Berry
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, hausner
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Implement the new '??' operator in analyzer. The new operator is only accepted by the tokenizer if the command-line option "--enable-null-aware-operators" is supplied. Only static analysis of '??' is implemented. However, the tests in tests/language/if_null_*_test.dart will also verify behavior once it is implemented. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44802

Patch Set 1 #

Patch Set 2 : Fix if_null_precedence_test for unchecked operation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -58 lines) Patch
M pkg/analyzer/lib/options.dart View 3 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 9 chunks +21 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 3 chunks +8 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 3 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_scanner.dart View 4 chunks +8 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 4 chunks +47 lines, -28 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_scanner_test.dart View 4 chunks +11 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 4 chunks +14 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +10 lines, -0 lines 0 comments Download
A tests/language/if_null_behavior_test.dart View 1 chunk +55 lines, -0 lines 0 comments Download
A tests/language/if_null_evaluation_order_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
A tests/language/if_null_precedence_test.dart View 1 1 chunk +66 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
See https://code.google.com/p/dart/source/detail?r=44726 for the associated spec changes. lrn@ and hausner@, don't feel obliged to review ...
5 years, 8 months ago (2015-03-29 01:54:45 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-03-29 02:05:17 UTC) #3
Paul Berry
5 years, 8 months ago (2015-03-31 12:38:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44802 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698