Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 104543002: Change the zone that late-added stream subscription callbacks are registered in. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen
Modified:
7 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the zone that late-added stream subscription callbacks are registered in. They are always called in the subscription's zone, but they were registered in the current zone. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=30896 Committed: https://code.google.com/p/dart/source/detail?r=30983

Patch Set 1 #

Patch Set 2 : Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -3 lines) Patch
M sdk/lib/async/stream_impl.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A tests/lib/async/stream_listen_zone_test.dart View 1 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
7 years ago (2013-12-04 13:07:58 UTC) #1
floitsch
LGTM.
7 years ago (2013-12-04 13:19:24 UTC) #2
floitsch
Maybe add a smoke test?
7 years ago (2013-12-04 13:19:42 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #2 manually as r30896 (presubmit successful).
7 years ago (2013-12-05 14:45:56 UTC) #4
Lasse Reichstein Nielsen
7 years ago (2013-12-09 11:25:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r30983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698