Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1045253003: Fix windows compilation error "cannot allocate an array of constant size 0". (Closed)

Created:
5 years, 8 months ago by siva
Modified:
5 years, 8 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix windows compilation error "cannot allocate an array of constant size 0". Committed: https://code.google.com/p/dart/source/detail?r=44817

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M runtime/bin/snapshot_in.cc View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
siva
TBR=hausner
5 years, 8 months ago (2015-03-31 19:32:15 UTC) #2
siva
Committed patchset #1 (id:1) manually as r44817 (presubmit successful).
5 years, 8 months ago (2015-03-31 19:32:27 UTC) #3
siva
TBR=hausner
5 years, 8 months ago (2015-03-31 19:39:53 UTC) #4
hausner
5 years, 8 months ago (2015-03-31 19:50:19 UTC) #5
Message was sent while issue was closed.
Lgtm with PS (post submit) comments.

https://codereview.chromium.org/1045253003/diff/1/runtime/bin/snapshot_in.cc
File runtime/bin/snapshot_in.cc (right):

https://codereview.chromium.org/1045253003/diff/1/runtime/bin/snapshot_in.cc#...
runtime/bin/snapshot_in.cc:25: 0,
The comment above ("string on the next line") no longer matches the code. Is the
0 also replaced? Maybe add a comment why the 0 is there in the first place.

https://codereview.chromium.org/1045253003/diff/1/runtime/bin/snapshot_in.cc#...
runtime/bin/snapshot_in.cc:35: static const uint8_t isolate_snapshot_buffer_[] =
{
Don't you need the same fix here?

Powered by Google App Engine
This is Rietveld 408576698