Issue 1044953004: Gracefully handle tests that print.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1044953004: Gracefully handle tests that print. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/unittest@master

Target Ref:
refs/heads/master

Visibility:
Public.

Gracefully handle tests that print. Prints from browser tests will be forwarded to the command-line, and the compact reporter will ensure that printed lines don't interfere with its status lines. Closes #13 R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/099065207a8bb187c57ea9e9d62edb2ff281255c

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+223 lines, -8 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/backend/invoker.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	lib/src/backend/live_test.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/src/backend/live_test_controller.dart	View	3 chunks	+21 lines, -2 lines	0 comments	Download
M	lib/src/runner/browser/iframe_listener.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/runner/browser/iframe_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/src/runner/reporter/compact.dart	View	4 chunks	+17 lines, -3 lines	0 comments	Download
M	lib/src/runner/reporter/no_io_compact.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/runner/vm/isolate_listener.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/src/runner/vm/isolate_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/backend/invoker_test.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	test/runner/browser/runner_test.dart	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	test/runner/compact_reporter_test.dart	View	2 chunks	+103 lines, -2 lines	0 comments	Download
M	test/runner/isolate_listener_test.dart	View	2 chunks	+20 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 8 months ago (2015-03-30 22:10:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
099065207a8bb187c57ea9e9d62edb2ff281255c (presubmit successful).