Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 104493002: Update status for long-running test on IE9. (Closed)

Created:
7 years ago by Johnni Winther
Modified:
7 years ago
CC:
reviews_dartlang.org, kustermann
Visibility:
Public.

Description

Update status for long-running test on IE9. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=30855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/co19/co19-dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
7 years ago (2013-12-04 12:43:36 UTC) #1
ahe
LGTM, but I'm seeing other issues with co19 Uri tests timing out. Perhaps we need ...
7 years ago (2013-12-04 12:56:46 UTC) #2
Johnni Winther
Committed patchset #1 manually as r30855 (presubmit successful).
7 years ago (2013-12-04 13:32:46 UTC) #3
kustermann
7 years ago (2013-12-04 13:46:25 UTC) #4
Message was sent while issue was closed.
LGTM

I agree with peter. There were/are quite a few of these co19 tests where tests
loop over a large range of values (we recently saw that also with a ListMixin
test -- co19 fixed it to make it faster AFAIK).

Powered by Google App Engine
This is Rietveld 408576698