Gracefully degrade if no source for completion

Gracefully degrade if no source for completion

BUG=dartbug.com/22617
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44796

[danrubel, 2015-03-30 15:39:42]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[danrubel, 2015-03-30 21:05:19]

Updated CL. PTAL

[scheglov, 2015-03-30 21:10:48]

lgtm

https://codereview.chromium.org/1044463004/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/domain_completion.dart (right):

https://codereview.chromium.org/1044463004/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/domain_completion.dart:180: if
(!context.exists(source)) {
Actually it is not guaranteed that AnalysisContext is not null.
It might be if the file is not a part of any context.

[danrubel, 2015-03-30 21:40:48]

https://codereview.chromium.org/1044463004/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/domain_completion.dart (right):

https://codereview.chromium.org/1044463004/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/domain_completion.dart:180: if
(!context.exists(source)) {
On 2015/03/30 21:10:48, scheglov wrote:
> Actually it is not guaranteed that AnalysisContext is not null.
> It might be if the file is not a part of any context.

Good catch. Fixed.

[danrubel, 2015-03-30 21:43:14]

Committed patchset #4 (id:60001) manually as 44796 (presubmit successful).