Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1044383002: improve parser recovery when top level function is missing parameters (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

improve parser recovery when top level function is missing parameters BUG=dartbug.com/23044 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44822

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 5 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-03-31 19:38:25 UTC) #2
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-03-31 19:41:21 UTC) #3
danrubel
5 years, 8 months ago (2015-03-31 20:49:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44822 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698