Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1044033003: Forward signals to pub run processes. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Forward signals to pub run processes. This is important for unittest, so it can catch SIGINT and gracefully clean up. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=44820

Patch Set 1 #

Patch Set 2 : Forward signals to snapshots. #

Patch Set 3 : Just ignore signals. #

Total comments: 4

Patch Set 4 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -0 lines) Patch
M sdk/lib/_internal/pub/lib/src/executable.dart View 1 2 4 chunks +28 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/pub.status View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A sdk/lib/_internal/pub/test/run/forwards_signal_posix_test.dart View 1 chunk +54 lines, -0 lines 0 comments Download
A sdk/lib/_internal/pub/test/run/forwards_signal_windows_test.dart View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
nweiz
5 years, 8 months ago (2015-03-30 23:49:01 UTC) #1
kevmoo
DBC https://codereview.chromium.org/1044033003/diff/40001/sdk/lib/_internal/pub/pub.status File sdk/lib/_internal/pub/pub.status (right): https://codereview.chromium.org/1044033003/diff/40001/sdk/lib/_internal/pub/pub.status#newcode18 sdk/lib/_internal/pub/pub.status:18: test/run/forwards_signal_windows_test: Skip SkipByDesign https://codereview.chromium.org/1044033003/diff/40001/sdk/lib/_internal/pub/pub.status#newcode22 sdk/lib/_internal/pub/pub.status:22: test/run/forwards_signal_posix_test: Skip SkipByDesign
5 years, 8 months ago (2015-03-31 03:06:10 UTC) #3
Bob Nystrom
LGTM!
5 years, 8 months ago (2015-03-31 19:21:11 UTC) #4
nweiz
Code review changes
5 years, 8 months ago (2015-03-31 19:46:12 UTC) #5
nweiz
https://codereview.chromium.org/1044033003/diff/40001/sdk/lib/_internal/pub/pub.status File sdk/lib/_internal/pub/pub.status (right): https://codereview.chromium.org/1044033003/diff/40001/sdk/lib/_internal/pub/pub.status#newcode18 sdk/lib/_internal/pub/pub.status:18: test/run/forwards_signal_windows_test: Skip On 2015/03/31 03:06:10, kevmoo wrote: > SkipByDesign ...
5 years, 8 months ago (2015-03-31 19:46:18 UTC) #6
nweiz
5 years, 8 months ago (2015-03-31 19:46:47 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 44820 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698