Change SDK/DartEditor versioning scheme to semantic versions.

Change SDK/DartEditor versioning scheme to semantic versions.

This means that all components of the SDK (i.e. DartVM, dart2js, dartanalyzer,
pub) will have the same semantic version string when invoking them with
'--version'. The version string is also present in "dart-sdk/version".

The editor will have an eclipse compatible version which consists of
major.minor.patch.qualifier.

The SDK versions look like this on our three channels:
  - bleeding-edge: 1.1.0-edge.30857
  - dev:           1.1.0-dev.2.42
  - stable:        1.1.0
The SDK versions comply with the semantic versioning standard, see:
http://semver.org/.

The DartEditor versions look like this on our three channels:
  - bleeding-edge: 1.1.0.edge_030857
  - dev:           1.1.0.dev_02_42
  - stable:        1.1.0.release
The DartEditor versions comply with semantic eclipse versioning scheme.
(The leading zeros are necessary due to lexicographic ordering.)

From both version schemes, it becomes clear on which channel a user is on.

R=danrubel@google.com, kasperl@google.com, rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30905

[kustermann, 2013-12-04 21:29:54]

It was decided that we move to semantic versions (please contact
dgrove@/rnystrom@ in case of questions about why).

This CL has the following effect (in addition to what is described in the CL
description):
- the build revision is not guaranteed to be in the version string
- the username is never in the version string
- the channel is deducible from the version string (but not always explicit)

If these three bits of information need to be present in one of our SDK
components (or in the editor), they have to be added in another way (i.e. not in
the version itself, but as additional info).
-- Though this will not happen in this CL.

[ahe, 2013-12-04 21:34:26]

+danrubel
-anrubel

[Bob Nystrom, 2013-12-04 22:28:19]

Super excited to see this go in!

https://codereview.chromium.org/104403005/diff/1/dart/editor/tools/features/c...
File
dart/editor/tools/features/com.google.dart.eclipse.feature_releng/build.properties
(right):

https://codereview.chromium.org/104403005/diff/1/dart/editor/tools/features/c...
dart/editor/tools/features/com.google.dart.eclipse.feature_releng/build.properties:1:
##############################################################################
Now the ### lines aren't the same length!

https://codereview.chromium.org/104403005/diff/1/dart/sdk/lib/_internal/pub/l...
File dart/sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/104403005/diff/1/dart/sdk/lib/_internal/pub/l...
dart/sdk/lib/_internal/pub/lib/src/sdk.dart:30: return version.major == 0 &&
version.minor == 1 && version.patch == 2;
This will break now, too, right?

Now that the bleeding edge SDK will have a valid version, I think you can just
remove the code that references it. In particular:

lib/src/command/lish.dart:99:

We do want to allow publishing from bleeding edge now since anyone on the Dart
team can publish a package, so this code should go away regardless:

lib/src/solver/backtracking_solver.dart:637:

I had to add this because SDK constraints would fail to solve on bleeding edge
builds since the version number was impossibly old. Now that we use wider SDK
constraints (since the SDK is stable!) and bleeding edge will have a current
version, we don't need this special case anymore.

https://codereview.chromium.org/104403005/diff/1/dart/sdk/lib/_internal/pub/l...
dart/sdk/lib/_internal/pub/lib/src/sdk.dart:44: return new
Version.parse(version);
\o/

https://codereview.chromium.org/104403005/diff/1/dart/tools/create_windows_in...
File dart/tools/create_windows_installer.py (right):

https://codereview.chromium.org/104403005/diff/1/dart/tools/create_windows_in...
dart/tools/create_windows_installer.py:104: raise Exception('Prerelease can not
be above 63')
"31" here and below.

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py
File dart/tools/utils.py (right):

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py#newcode243
dart/tools/utils.py:243: # Return the base part of the version,
Major.Minor.Build.Patch,
Update this comment.

[kasperl, 2013-12-05 08:29:58]

https://codereview.chromium.org/104403005/diff/1/dart/tools/create_windows_in...
File dart/tools/create_windows_installer.py (right):

https://codereview.chromium.org/104403005/diff/1/dart/tools/create_windows_in...
dart/tools/create_windows_installer.py:105: if prerelease > 31:
Check prerelease_patch instead of prerelease.

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py
File dart/tools/utils.py (right):

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py#newcode257
dart/tools/utils.py:257: postfix = '-edge.%s' % GetSVNRevision()
Why did you choose edge over be in the postfix string here and in the eclipse
version qualifier?

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py#newcode309
dart/tools/utils.py:309: channel = match_against('^CHANNEL ([A-Za-z0-9]+)$',
content)
Looks like this allows the VERSION file to contain comments. Maybe we should add
a few to it to make it clear what PRERELEASE and PRERELEASE_PATCH are supposed
to be used for.

[kustermann, 2013-12-05 09:27:26]

PTAL

https://codereview.chromium.org/104403005/diff/1/dart/editor/tools/features/c...
File
dart/editor/tools/features/com.google.dart.eclipse.feature_releng/build.properties
(right):

https://codereview.chromium.org/104403005/diff/1/dart/editor/tools/features/c...
dart/editor/tools/features/com.google.dart.eclipse.feature_releng/build.properties:1:
##############################################################################
On 2013/12/04 22:28:20, Bob Nystrom wrote:
> Now the ### lines aren't the same length!

I probably pressed 'x' at an inappropriate time in VIM.

Good to see that comment/whitespace has also top priority in seattle -- not just
in Aarhus :)

https://codereview.chromium.org/104403005/diff/1/dart/sdk/lib/_internal/pub/l...
File dart/sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/104403005/diff/1/dart/sdk/lib/_internal/pub/l...
dart/sdk/lib/_internal/pub/lib/src/sdk.dart:30: return version.major == 0 &&
version.minor == 1 && version.patch == 2;
On 2013/12/04 22:28:20, Bob Nystrom wrote:
> This will break now, too, right?
> 
> Now that the bleeding edge SDK will have a valid version, I think you can just
> remove the code that references it. In particular:
> 
> lib/src/command/lish.dart:99:
> 
> We do want to allow publishing from bleeding edge now since anyone on the Dart
> team can publish a package, so this code should go away regardless:
> 
> lib/src/solver/backtracking_solver.dart:637:
> 
> I had to add this because SDK constraints would fail to solve on bleeding edge
> builds since the version number was impossibly old. Now that we use wider SDK
> constraints (since the SDK is stable!) and bleeding edge will have a current
> version, we don't need this special case anymore.

I removed the code.

https://codereview.chromium.org/104403005/diff/1/dart/tools/create_windows_in...
File dart/tools/create_windows_installer.py (right):

https://codereview.chromium.org/104403005/diff/1/dart/tools/create_windows_in...
dart/tools/create_windows_installer.py:104: raise Exception('Prerelease can not
be above 63')
On 2013/12/04 22:28:20, Bob Nystrom wrote:
> "31" here and below.

Done.

https://codereview.chromium.org/104403005/diff/1/dart/tools/create_windows_in...
dart/tools/create_windows_installer.py:105: if prerelease > 31:
On 2013/12/05 08:29:58, kasperl wrote:
> Check prerelease_patch instead of prerelease.

Thanks for catching this one.

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py
File dart/tools/utils.py (right):

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py#newcode243
dart/tools/utils.py:243: # Return the base part of the version,
Major.Minor.Build.Patch,
On 2013/12/04 22:28:20, Bob Nystrom wrote:
> Update this comment.

Removed comment, it's obvious what it returns.

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py#newcode257
dart/tools/utils.py:257: postfix = '-edge.%s' % GetSVNRevision()
On 2013/12/05 08:29:58, kasperl wrote:
> Why did you choose edge over be in the postfix string here and in the eclipse
> version qualifier?

It depends a bit on how we will do releases, but this will guarantee that if we
have a pubspec.yaml file with an sdk constraint as follows:
  environment:
    sdk: ">=1.1.0-dev.2.4"
our bleeding edge builds will satisfy that constraint with
with '1.1.0-edge.42000' since "edge" > "dev" but "1.1.0-be.4200" would not
satisfy this (AFAIK).

(It has of course the disadvantage that all bleeding edge builds with the same
major.minor.patch will be sorted higher than dev, but that is acceptable [the
problem in general is not solvable]).

I don't know if we will see pubspec.yaml files with an dev sdk constraint.


[If that concern is not justified, I'm more than happy to change it to the
channel name 'be']

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py#newcode309
dart/tools/utils.py:309: channel = match_against('^CHANNEL ([A-Za-z0-9]+)$',
content)
On 2013/12/05 08:29:58, kasperl wrote:
> Looks like this allows the VERSION file to contain comments. Maybe we should
add
> a few to it to make it clear what PRERELEASE and PRERELEASE_PATCH are supposed
> to be used for.

That came to my mind as well, but I wasn't sure if the ant xml files could
handle it, but apparently it works.

I've added some comments, please take a look at them.

[kasperl, 2013-12-05 09:44:47]

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py
File dart/tools/utils.py (right):

https://codereview.chromium.org/104403005/diff/1/dart/tools/utils.py#newcode257
dart/tools/utils.py:257: postfix = '-edge.%s' % GetSVNRevision()
On 2013/12/05 09:27:27, kustermann wrote:
> On 2013/12/05 08:29:58, kasperl wrote:
> > Why did you choose edge over be in the postfix string here and in the
eclipse
> > version qualifier?
> 
> It depends a bit on how we will do releases, but this will guarantee that if
we
> have a pubspec.yaml file with an sdk constraint as follows:
>   environment:
>     sdk: ">=1.1.0-dev.2.4"
> our bleeding edge builds will satisfy that constraint with
> with '1.1.0-edge.42000' since "edge" > "dev" but "1.1.0-be.4200" would not
> satisfy this (AFAIK).
> 
> (It has of course the disadvantage that all bleeding edge builds with the same
> major.minor.patch will be sorted higher than dev, but that is acceptable [the
> problem in general is not solvable]).
> 
> I don't know if we will see pubspec.yaml files with an dev sdk constraint.
> 
> 
> [If that concern is not justified, I'm more than happy to change it to the
> channel name 'be']

That makes sense to me. Let's stick to edge. Maybe factor the shared strings out
(edge and dev) and put a comment on why they are chosen that way near the string
definitions?

[kasperl, 2013-12-05 09:49:47]

LGTM. Should we check that the different version components are used
consistently somewhere? The nice comment in tools/VERSION constrains what we (as
a team) consider valid versions.

https://codereview.chromium.org/104403005/diff/40001/dart/sdk/lib/_internal/p...
File dart/sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/104403005/diff/40001/dart/sdk/lib/_internal/p...
dart/sdk/lib/_internal/pub/lib/src/sdk.dart:25: Version version = _getVersion();
Should this be final? Not your code so maybe don't mess with it.

https://codereview.chromium.org/104403005/diff/40001/dart/tools/VERSION
File dart/tools/VERSION (right):

https://codereview.chromium.org/104403005/diff/40001/dart/tools/VERSION#newcode4
dart/tools/VERSION:4: #  * New release cycle has began (i.e. stable release was
just made):
began -> begun

https://codereview.chromium.org/104403005/diff/40001/dart/tools/create_editor.py
File dart/tools/create_editor.py (right):

https://codereview.chromium.org/104403005/diff/40001/dart/tools/create_editor...
dart/tools/create_editor.py:191: '-Ddart.version.full=' + utils.GetVersion(),
Move this down near the qualifier?

[kustermann, 2013-12-05 10:42:05]

We could add a presubmit check for tools/VERSION. The issue is that changes on
trunk and stable branches are often done with "svn commit" -- which doesn't do
presubmit checks.

Though I could put asserts into tools/utils.py?!

https://codereview.chromium.org/104403005/diff/40001/dart/sdk/lib/_internal/p...
File dart/sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/104403005/diff/40001/dart/sdk/lib/_internal/p...
dart/sdk/lib/_internal/pub/lib/src/sdk.dart:25: Version version = _getVersion();
On 2013/12/05 09:49:47, kasperl wrote:
> Should this be final? Not your code so maybe don't mess with it.

I'm not messing with it.

https://codereview.chromium.org/104403005/diff/40001/dart/tools/VERSION
File dart/tools/VERSION (right):

https://codereview.chromium.org/104403005/diff/40001/dart/tools/VERSION#newcode4
dart/tools/VERSION:4: #  * New release cycle has began (i.e. stable release was
just made):
On 2013/12/05 09:49:47, kasperl wrote:
> began -> begun

Done.

https://codereview.chromium.org/104403005/diff/40001/dart/tools/create_editor.py
File dart/tools/create_editor.py (right):

https://codereview.chromium.org/104403005/diff/40001/dart/tools/create_editor...
dart/tools/create_editor.py:191: '-Ddart.version.full=' + utils.GetVersion(),
On 2013/12/05 09:49:47, kasperl wrote:
> Move this down near the qualifier?

Done.

[Bob Nystrom, 2013-12-05 17:40:06]

After you address my comment, pub changes LGTM.

https://codereview.chromium.org/104403005/diff/40001/dart/sdk/lib/_internal/p...
File dart/sdk/lib/_internal/pub/lib/src/command/lish.dart (right):

https://codereview.chromium.org/104403005/diff/40001/dart/sdk/lib/_internal/p...
dart/sdk/lib/_internal/pub/lib/src/command/lish.dart:99: if (server.toString()
== HostedSource.defaultUrl && !dryRun) {
You'll want to remove this entire if block (and the above comment). This would
prevent anyone from publishing anything to pub. :)

https://codereview.chromium.org/104403005/diff/40001/dart/sdk/lib/_internal/p...
File dart/sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/104403005/diff/40001/dart/sdk/lib/_internal/p...
dart/sdk/lib/_internal/pub/lib/src/sdk.dart:25: Version version = _getVersion();
On 2013/12/05 09:49:47, kasperl wrote:
> Should this be final? Not your code so maybe don't mess with it.

No, see the above doc comment.

[danrubel, 2013-12-05 18:29:18]

lgtm

[kustermann, 2013-12-05 18:31:59]

@Dan: Could you take a look at the ant changes?

https://codereview.chromium.org/104403005/diff/40001/dart/sdk/lib/_internal/p...
File dart/sdk/lib/_internal/pub/lib/src/command/lish.dart (right):

https://codereview.chromium.org/104403005/diff/40001/dart/sdk/lib/_internal/p...
dart/sdk/lib/_internal/pub/lib/src/command/lish.dart:99: if (server.toString()
== HostedSource.defaultUrl && !dryRun) {
On 2013/12/05 17:40:06, Bob Nystrom wrote:
> You'll want to remove this entire if block (and the above comment). This would
> prevent anyone from publishing anything to pub. :)

Sure, that was pretty stupid.

[kustermann, 2013-12-05 18:34:34]

@all: Thanks for reviewing.

[kustermann, 2013-12-05 18:35:18]

Committed patchset #3 manually as r30905 (presubmit successful).