Issue 1043953002: Fix some Observatory issues that crept in with my last couple changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1043953002: Fix some Observatory issues that crept in with my last couple changes. (Closed)

Created:
5 years, 8 months ago by turnidge

Modified:
5 years, 8 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Fix some Observatory issues that crept in with my last couple changes. - need ObservatoryApplication class in ObservatoryDebugger - mainPort is gone now BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44818

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -24 lines)			Patch
M	runtime/observatory/lib/src/elements/debugger.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/isolate_view.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/observatory/test/async_generator_breakpoint_test.dart	View	1	3 chunks	+11 lines, -10 lines	0 comments	Download
M	runtime/observatory/test/coverage_test.dart	View	1	4 chunks	+9 lines, -9 lines	0 comments	Download
M	runtime/observatory/test/debugging_test.dart	View	1	4 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

turnidge

5 years, 8 months ago (2015-03-31 19:33:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 44818 (presubmit successful).