Chromium Code Reviews
DescriptionRework handling of factory redirects in constant evaluation.
This change limits the set of elements that need to be examined in
order to determine the constant evaluation dependency graph.
Previously, when encountering a constant constructor invocation, we
would chase the sequence of factory redirects to a non-redirecting
constructor (being careful to avoid infinite regress in the case of
invalid input), and then mark the invocation as dependent on the
non-redirecting constructor. Now, we mark the invocation as dependent
on the constructor it immediately references, and mark redirecting
factory constructors as dependent on the constructors they redirect
to.
This is a prerequisite to converting constant evaluation over to the
new task model, since once we're in the new task model there will be
no guarantee that the full sequence of factory redirects has been
resolved at the time we need to compute dependencies.
R=brianwilkerson@google.com
Committed: https://code.google.com/p/dart/source/detail?r=44797
Patch Set 1 #
Messages
Total messages: 4 (1 generated)
|
|||||||||||||||||||