Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1043583002: Scanner/parser support for DEP 9 (null-aware operators). (Closed)

Created:
5 years, 9 months ago by Paul Berry
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Scanner/parser support for DEP 9 (null-aware operators). This adds scanner and parser support for the operators '?.', '??', and '??='. Support is not yet enabled--it is only turned on during the unit tests for the new tokens and AST's. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44770

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -27 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 6 chunks +24 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 7 chunks +98 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 12 chunks +79 lines, -3 lines 2 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
5 years, 9 months ago (2015-03-27 22:07:58 UTC) #2
Brian Wilkerson
LGTM! https://codereview.chromium.org/1043583002/diff/1/pkg/analyzer/test/generated/parser_test.dart File pkg/analyzer/test/generated/parser_test.dart (right): https://codereview.chromium.org/1043583002/diff/1/pkg/analyzer/test/generated/parser_test.dart#newcode4856 pkg/analyzer/test/generated/parser_test.dart:4856: expect(propertyAccess.operator.type, TokenType.PERIOD); I generally prefer to leave in ...
5 years, 9 months ago (2015-03-27 22:56:37 UTC) #3
Paul Berry
https://codereview.chromium.org/1043583002/diff/1/pkg/analyzer/test/generated/parser_test.dart File pkg/analyzer/test/generated/parser_test.dart (right): https://codereview.chromium.org/1043583002/diff/1/pkg/analyzer/test/generated/parser_test.dart#newcode4856 pkg/analyzer/test/generated/parser_test.dart:4856: expect(propertyAccess.operator.type, TokenType.PERIOD); On 2015/03/27 22:56:37, Brian Wilkerson wrote: > ...
5 years, 9 months ago (2015-03-28 02:25:09 UTC) #4
Paul Berry
5 years, 9 months ago (2015-03-28 02:25:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44770 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698