Issue 1043473002: Fix the value of multiline strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1043473002: Fix the value of multiline strings (Closed)

Created:
5 years, 9 months ago by Brian Wilkerson

Modified:
5 years, 9 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Fix the value of multiline strings. This re-applies the changes in 44722 (which was reverted in 44734) and fixes another bug that was uncovered by that change. R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=44752

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -13 lines)			Patch
M	pkg/analyzer/lib/src/generated/ast.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View		3 chunks	+48 lines, -8 lines	0 comments	Download
M	pkg/analyzer/test/generated/ast_test.dart	View	1	1 chunk	+11 lines, -4 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View		1 chunk	+76 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Brian Wilkerson

This also fixes a long-standing bug that was uncovered by the changes.

5 years, 9 months ago (2015-03-27 16:51:01 UTC) #2

Paul Berry

It would be nice for the commit message to mention that this CL also un-does ...

5 years, 9 months ago (2015-03-27 17:58:51 UTC) #3

Brian Wilkerson

> It would be nice for the commit message to mention that this CL also ...

5 years, 9 months ago (2015-03-27 18:25:17 UTC) #4

Brian Wilkerson

5 years, 9 months ago (2015-03-27 18:26:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 44752 (presubmit successful).