Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1042963002: Avoid infinite loop if const constructor redirects don't reach a fixed point. (Closed)

Created:
5 years, 8 months ago by Paul Berry
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Avoid infinite loop if const constructor redirects don't reach a fixed point. BUG=dartbug.com/23038 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44789

Patch Set 1 #

Patch Set 2 : Add missing copyright notice. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -107 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 32 chunks +85 lines, -102 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/language/regress_23038_test.dart View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 8 months ago (2015-03-30 20:48:50 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-03-30 20:50:38 UTC) #3
Paul Berry
5 years, 8 months ago (2015-03-30 21:00:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698