Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1042403002: add UNKNOWN_SOURCE error code and remove 2 unused legacy error codes (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

add UNKNOWN_SOURCE error code and remove 2 unused legacy error codes BUG=dartbug.com/23039 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44787

Patch Set 1 #

Patch Set 2 : restore legacy error codes #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RequestErrorCode.java View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 4 chunks +10 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-03-30 19:22:21 UTC) #2
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-03-30 19:31:45 UTC) #3
danrubel
5 years, 8 months ago (2015-03-30 20:12:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 44787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698