Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1042133002: Generate warnings for assignment to a type. (Closed)

Created:
5 years, 8 months ago by Paul Berry
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Generate warnings for assignment to a type. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44774

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 3 chunks +45 lines, -0 lines 0 comments Download
A tests/language/assign_to_type_test.dart View 1 chunk +29 lines, -0 lines 2 comments Download
M tests/language/language_analyzer.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
5 years, 8 months ago (2015-03-29 20:45:38 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1042133002/diff/1/tests/language/assign_to_type_test.dart File tests/language/assign_to_type_test.dart (right): https://codereview.chromium.org/1042133002/diff/1/tests/language/assign_to_type_test.dart#newcode1 tests/language/assign_to_type_test.dart:1: // Copyright (c) 2012, the Dart project authors. ...
5 years, 8 months ago (2015-03-29 23:30:53 UTC) #4
Paul Berry
https://codereview.chromium.org/1042133002/diff/1/tests/language/assign_to_type_test.dart File tests/language/assign_to_type_test.dart (right): https://codereview.chromium.org/1042133002/diff/1/tests/language/assign_to_type_test.dart#newcode1 tests/language/assign_to_type_test.dart:1: // Copyright (c) 2012, the Dart project authors. Please ...
5 years, 8 months ago (2015-03-30 00:07:05 UTC) #5
Paul Berry
5 years, 8 months ago (2015-03-30 00:08:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 44774 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698