Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1041503002: Allow tests to be selected by name. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Reorder changelog. #

Patch Set 3 : cr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -3 lines) Patch
M CHANGELOG.md View 1 1 chunk +6 lines, -1 line 0 comments Download
M bin/unittest.dart View 1 2 2 chunks +40 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/runner_test.dart View 1 2 2 chunks +99 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
nweiz
5 years, 9 months ago (2015-03-26 23:29:31 UTC) #1
kevmoo
Also: running this pub 'pub downgrade' – even when adding string_scanner, crashes. I think we ...
5 years, 8 months ago (2015-03-28 22:02:26 UTC) #2
nweiz
https://codereview.chromium.org/1041503002/diff/1/bin/unittest.dart File bin/unittest.dart (right): https://codereview.chromium.org/1041503002/diff/1/bin/unittest.dart#newcode32 bin/unittest.dart:32: 'Regular expression syntax is supported.'); On 2015/03/28 22:02:26, kevmoo ...
5 years, 8 months ago (2015-03-30 19:45:41 UTC) #3
kevmoo
https://codereview.chromium.org/1041503002/diff/1/bin/unittest.dart File bin/unittest.dart (right): https://codereview.chromium.org/1041503002/diff/1/bin/unittest.dart#newcode32 bin/unittest.dart:32: 'Regular expression syntax is supported.'); On 2015/03/30 19:45:41, nweiz ...
5 years, 8 months ago (2015-03-30 19:51:49 UTC) #4
nweiz
https://codereview.chromium.org/1041503002/diff/1/bin/unittest.dart File bin/unittest.dart (right): https://codereview.chromium.org/1041503002/diff/1/bin/unittest.dart#newcode32 bin/unittest.dart:32: 'Regular expression syntax is supported.'); On 2015/03/30 19:51:49, kevmoo ...
5 years, 8 months ago (2015-03-30 20:08:09 UTC) #5
kevmoo
lgtm
5 years, 8 months ago (2015-03-30 20:13:15 UTC) #6
nweiz
5 years, 8 months ago (2015-03-30 21:23:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
64dfda5c1fc9423acd59801f44c075085bfdd283 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698