Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1041283002: GetContentTask should catch exceptions and wrap them into AnalysisExceptions. (Closed)

Created:
5 years, 8 months ago by scheglov
Modified:
5 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

GetContentTask should catch exceptions and wrap them into AnalysisExceptions. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M pkg/analyzer/lib/src/task/general.dart View 2 chunks +9 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/general_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 8 months ago (2015-03-30 21:06:21 UTC) #1
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-03-30 21:09:22 UTC) #2
scheglov
5 years, 8 months ago (2015-03-30 21:16:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44792 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698