Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1040623002: Clean up naming scheme for reflection names. (Closed)

Created:
5 years, 9 months ago by herhut
Modified:
5 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, floitsch, zarah
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : Exclude methods that are not reflectable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -25 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 3 chunks +7 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart View 1 2 chunks +6 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_mirrors.dart View 1 2 4 chunks +11 lines, -6 lines 0 comments Download
A tests/lib/mirrors/optional_parameters_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
herhut
5 years, 9 months ago (2015-03-27 09:04:06 UTC) #3
ahe
lgtm
5 years, 9 months ago (2015-03-27 12:16:10 UTC) #4
herhut
Committed patchset #2 (id:40001) manually as 44732 (presubmit successful).
5 years, 9 months ago (2015-03-27 12:28:13 UTC) #5
herhut
We have to make sure that we do not try to build a methodmirror for ...
5 years, 9 months ago (2015-03-27 14:14:54 UTC) #6
ahe
LGTM as you have promise me to create a single regression test that will prevent ...
5 years, 9 months ago (2015-03-27 14:41:12 UTC) #7
herhut
5 years, 9 months ago (2015-03-27 14:43:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as 44736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698