Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1040573002: Fix NPE in ErrorReporter (issue 22980) (Closed)

Created:
5 years, 9 months ago by Brian Wilkerson
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix NPE in ErrorReporter (issue 22980) R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -15 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +10 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 5 chunks +34 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 9 months ago (2015-03-27 14:40:52 UTC) #2
scheglov
LGTM
5 years, 9 months ago (2015-03-27 15:20:44 UTC) #3
Brian Wilkerson
5 years, 9 months ago (2015-03-27 15:40:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698