Issue 1040563004: Make "pub run foo" run "pub run foo:foo" rather than "pub run bin/foo"

Issue 1040563004: Make "pub run foo" run "pub run foo:foo" rather than "pub run bin/foo" (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Make "pub run foo" run "pub run foo:foo" rather than "pub run bin/foo" R=rnystrom@google.com BUG= dartbug.com/22129 Committed: https://code.google.com/p/dart/source/detail?r=44819

Patch Set 3 : Remove bogus changes. #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -20 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/command/run.dart	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/preprocess.dart	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/run/app_can_read_from_stdin_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/run/displays_transformer_logs_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/run/does_not_run_on_transformer_error_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/run/doesnt_load_an_unnecessary_transformer_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/run/ignores_explicit_dart2js_transformer_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/run/mode_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/run/nonexistent_script_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/run/passes_along_arguments_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/run/runs_a_generated_script_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/test/run/runs_app_in_entrypoint_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	sdk/lib/_internal/pub/test/run/runs_app_in_entrypoint_with_warning_test.dart	View		2 chunks	+8 lines, -0 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/run/runs_shorthand_app_in_dependency_test.dart	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/run/runs_transformer_in_entrypoint_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/1040563004/diff/1/sdk/lib/_internal/pub/lib/src/command/run.dart File sdk/lib/_internal/pub/lib/src/command/run.dart (right): https://codereview.chromium.org/1040563004/diff/1/sdk/lib/_internal/pub/lib/src/command/run.dart#newcode19 sdk/lib/_internal/pub/lib/src/command/run.dart:19: final _identifier = new RegExp(r"^[a-zA-Z_][a-zA-Z0-9_]*$"); We have this ...

5 years, 8 months ago (2015-03-31 19:19:48 UTC) #2

nweiz

https://codereview.chromium.org/1040563004/diff/1/sdk/lib/_internal/pub/lib/src/command/run.dart File sdk/lib/_internal/pub/lib/src/command/run.dart (right): https://codereview.chromium.org/1040563004/diff/1/sdk/lib/_internal/pub/lib/src/command/run.dart#newcode19 sdk/lib/_internal/pub/lib/src/command/run.dart:19: final _identifier = new RegExp(r"^[a-zA-Z_][a-zA-Z0-9_]*$"); On 2015/03/31 19:19:48, Bob ...

5 years, 8 months ago (2015-03-31 19:36:16 UTC) #3

nweiz

5 years, 8 months ago (2015-03-31 19:44:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 44819 (presubmit successful).

Expand Messages | Collapse Messages