Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1040083007: do not report _ as unused variable (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

do not report _ as unused variable BUG=dartbug.com/23050 R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44825

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +14 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
5 years, 8 months ago (2015-03-31 20:55:25 UTC) #2
scheglov
I'm not quite agree with the gist of the issue, but implementation LGTM
5 years, 8 months ago (2015-03-31 21:35:32 UTC) #3
Brian Wilkerson
LGTM
5 years, 8 months ago (2015-03-31 21:35:59 UTC) #5
danrubel
5 years, 8 months ago (2015-03-31 21:56:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698