Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1039713002: Rename MethodInvocation.period to MethodInvocation.operator. (Closed)

Created:
5 years, 8 months ago by Paul Berry
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Rename MethodInvocation.period to MethodInvocation.operator. The name is inaccurate--if the method invocation is part of a cascade, it is the ".." operator. It's going to get even more inaccurate when null-aware operators are added, since it will also be used to represent "?.". Deprecated getters and setters named "period" are added to avoid breaking the analyzer API. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=44744

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -17 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 9 chunks +37 lines, -14 lines 2 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
5 years, 8 months ago (2015-03-27 16:14:43 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1039713002/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/1039713002/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode11763 pkg/analyzer/lib/src/generated/ast.dart:11763: * The period that separates the target from ...
5 years, 8 months ago (2015-03-27 16:26:25 UTC) #4
Paul Berry
Committed patchset #1 (id:1) manually as 44744 (presubmit successful).
5 years, 8 months ago (2015-03-27 16:38:41 UTC) #5
Paul Berry
5 years, 8 months ago (2015-03-27 16:38:58 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1039713002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/ast.dart (right):

https://codereview.chromium.org/1039713002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/ast.dart:11763: * The period that separates the
target from the method name in an ordinary
On 2015/03/27 16:26:24, Brian Wilkerson wrote:
> I'd prefer the following (because it will expand to other cases more easily):
> 
> The operator that separates the target from the method name, or `null` if
there
> is no target. In an ordinary method invocation this will be a period ('.'). In
a
> cascade section this will be the cascade operator ('..').

Done.

Powered by Google App Engine
This is Rietveld 408576698