Issue 103863004: Revert "Generate tear-off closures dynamically."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103863004: Revert "Generate tear-off closures dynamically." (Closed)

Created:
7 years ago by ahe

Modified:
7 years ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Generate tear-off closures dynamically." This reverts r30955. Committed: https://code.google.com/p/dart/source/detail?r=30961

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+613 lines, -1111 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js/nodes.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	4 chunks	+0 lines, -9 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_builder.dart	View	2 chunks	+4 lines, -35 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart	View	6 chunks	+22 lines, -14 lines	0 comments	Download
A	dart/sdk/lib/_internal/compiler/implementation/js_emitter/closure_invocation_element.dart	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View	8 chunks	+20 lines, -17 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart	View	8 chunks	+356 lines, -234 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/declarations.dart	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart	View	4 chunks	+18 lines, -6 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/nsm_emitter.dart	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart	View	7 chunks	+7 lines, -184 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/universe/universe.dart	View	3 chunks	+4 lines, -21 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/isolate_helper.dart	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_helper.dart	View	8 chunks	+46 lines, -394 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	17 chunks	+80 lines, -149 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_rti.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/mirrors_used_test.dart	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	dart/tests/compiler/dart2js/static_closure_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/types_of_captured_variables_test.dart	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/deferred/deferred_function_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/mirror_invalid_field_access4_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	dart/tests/compiler/dart2js_extra/mirror_invalid_invoke2_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js_extra/mirror_invalid_invoke3_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/lib/lib.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

LGTM :(

Expand Messages | Collapse Messages