Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1038353002: Revert "Fix value computation for multi-line strings (issue 22993)" (Closed)

Created:
5 years, 9 months ago by ricow1
Modified:
5 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Fix value computation for multi-line strings (issue 22993)" This reverts revision 44722 This is causing test failures: http://build.chromium.org/p/client.dart/builders/pub-linux-be/builds/11761/steps/pub%20and%20pkg%20%20tests%20failures/logs/stdio R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -128 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +6 lines, -52 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
5 years, 9 months ago (2015-03-27 10:22:45 UTC) #1
ricow1
tbr
5 years, 9 months ago (2015-03-27 13:59:05 UTC) #2
ricow1
5 years, 9 months ago (2015-03-27 13:59:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698