Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1038283004: Evaluate parameters of static calls that throw NSM (Closed)

Created:
5 years, 8 months ago by hausner
Modified:
5 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Evaluate parameters of static calls that throw NSM The spec mandates that parameters of calls get evaluated even if the function can’t be resolved and the call results in a noSuchMethod being thrown. Fixes issue 17382. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44784

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M runtime/vm/parser.cc View 1 1 chunk +4 lines, -9 lines 0 comments Download
M tests/language/language_analyzer.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A tests/language/regress_17382_test.dart View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hausner
5 years, 8 months ago (2015-03-30 16:24:31 UTC) #2
hausner
Added regression test.
5 years, 8 months ago (2015-03-30 17:38:23 UTC) #3
srdjan
lgtm
5 years, 8 months ago (2015-03-30 17:40:52 UTC) #4
hausner
5 years, 8 months ago (2015-03-30 19:31:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r44784 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698