Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 103803011: Fix tracesummary.dart (Closed)

Created:
7 years ago by Cutch
Modified:
7 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Properly calculate inclusive and exclusive counts on symbols. - Output ticks and percentage of total ticks. - Allow user to specify symbol count as command line argument. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=31224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -20 lines) Patch
M tools/tracesummary.dart View 5 chunks +54 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
7 years ago (2013-12-18 01:13:05 UTC) #1
scheglov
LGTM Much better results for foo/bar sample.
7 years ago (2013-12-18 01:58:46 UTC) #2
Cutch
7 years ago (2013-12-18 14:52:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31224 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698