Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1037483002: Add support for controlling HttpResponse.bufferOutput to shelf_io. (Closed)

Created:
5 years, 9 months ago by nweiz
Modified:
5 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/shelf@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for controlling HttpResponse.bufferOutput to shelf_io. Closes #7 R=kevmoo@google.com Committed: https://github.com/dart-lang/shelf/commit/0828929740d947141b8ad90995c96993e6c55584

Patch Set 1 #

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -11 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/shelf_io.dart View 3 chunks +21 lines, -10 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/shelf_io_test.dart View 1 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 9 months ago (2015-03-24 19:25:58 UTC) #1
kevmoo
LGTM w/ questions 1 - would love to see a test for this – or ...
5 years, 9 months ago (2015-03-24 19:32:17 UTC) #2
nweiz
On 2015/03/24 19:32:17, kevmoo wrote: > LGTM w/ questions > > 1 - would love ...
5 years, 9 months ago (2015-03-24 19:58:28 UTC) #3
nweiz
Code review changes
5 years, 9 months ago (2015-03-24 19:58:57 UTC) #4
kevmoo
Still LGTM
5 years, 9 months ago (2015-03-25 07:34:25 UTC) #5
nweiz
5 years, 9 months ago (2015-03-25 22:13:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0828929740d947141b8ad90995c96993e6c55584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698