Issue 1037343002: Mark code when it instantiates an unloaded deferred type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1037343002: Mark code when it instantiates an unloaded deferred type (Closed)

Created:
5 years, 9 months ago by hausner

Modified:
5 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Mark code when it instantiates an unloaded deferred type The VM registers code objects that depend on deferred library prefixes, e.g. when calling a function in the deferred library. We didn’t do this when instantiating a type from the deferred library. This is a fix for issue 22443. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=44757

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -9 lines)			Patch
M	runtime/vm/parser.cc	View	1 2	1 chunk	+22 lines, -9 lines	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/regress_22443_lib.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A	tests/language/regress_22443_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hausner

5 years, 9 months ago (2015-03-27 19:39:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as r44757 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages