Issue 1037333002: volatile -> const, where possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1037333002: volatile -> const, where possible (Closed)

Created:
5 years, 9 months ago by koda

Modified:
5 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

volatile -> const, where possible These 'volatile' modifiers were added to silence warnings about setjmp/longjmp clobbering, but 'const' works too and allows more optimization. TBR=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=44749

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -19 lines)			Patch
M	runtime/vm/compiler.cc	View	7 chunks	+12 lines, -12 lines	0 comments	Download
M	runtime/vm/thread.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/thread.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

koda

5 years, 9 months ago (2015-03-27 18:11:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r44749 (presubmit successful).