Implement ClassMirror.reflectedType in dart2js.

Implement ClassMirror.reflectedType in dart2js.

BUG=http://dartbug.com/12607
R=ahe@google.com, zarah@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31200

[rmacnak, 2013-12-07 01:40:25]

https://codereview.chromium.org/103713006/diff/1/sdk/lib/_internal/lib/js_mir...
File sdk/lib/_internal/lib/js_mirrors.dart (left):

https://codereview.chromium.org/103713006/diff/1/sdk/lib/_internal/lib/js_mir...
sdk/lib/_internal/lib/js_mirrors.dart:951: String get _mangledName =>
'${_class._mangledName}<$_typeArguments>';
This value was slightly different from the incoming mangledName, and would lead
to things like A != A<dynamic>.

[ahe, 2013-12-09 13:11:27]

https://codereview.chromium.org/103713006/diff/1/sdk/lib/_internal/lib/js_mir...
File sdk/lib/_internal/lib/js_mirrors.dart (left):

https://codereview.chromium.org/103713006/diff/1/sdk/lib/_internal/lib/js_mir...
sdk/lib/_internal/lib/js_mirrors.dart:951: String get _mangledName =>
'${_class._mangledName}<$_typeArguments>';
On 2013/12/07 01:40:25, Ryan Macnak wrote:
> This value was slightly different from the incoming mangledName, and would
lead
> to things like A != A<dynamic>.

I'm not sure why preserving the mangledName is fixing those problems, and I'm
not sure it is safe for future changes that I predict will happen to the mirror
system.

In particular, I expect that we will need to provide API to apply type arguments
to an original declaration.

Could you provide a complete example that doesn't work, or a link to a test?

[rmacnak, 2013-12-09 18:06:29]

On 2013/12/09 13:11:27, ahe wrote:
>
https://codereview.chromium.org/103713006/diff/1/sdk/lib/_internal/lib/js_mir...
> File sdk/lib/_internal/lib/js_mirrors.dart (left):
> 
>
https://codereview.chromium.org/103713006/diff/1/sdk/lib/_internal/lib/js_mir...
> sdk/lib/_internal/lib/js_mirrors.dart:951: String get _mangledName =>
> '${_class._mangledName}<$_typeArguments>';
> On 2013/12/07 01:40:25, Ryan Macnak wrote:
> > This value was slightly different from the incoming mangledName, and would
> lead
> > to things like A != A<dynamic>.
> 
> I'm not sure why preserving the mangledName is fixing those problems, and I'm
> not sure it is safe for future changes that I predict will happen to the
mirror
> system.
> 
> In particular, I expect that we will need to provide API to apply type
arguments
> to an original declaration.
> 
> Could you provide a complete example that doesn't work, or a link to a test?

The reflected_type_test fails.

For example, 

import 'dart:mirrors';

class G<T> {}

main() {
 print(reflectType(G).mangledName1); // The one passed in: G
 print(reflectType(G).mangledName2); // The constructed one: G<dynamic>
 print(G); // G, not G<dynamic>
}

[rmacnak, 2013-12-13 19:14:54]

Creating the canonical rep directly instead of relying on the passed mangled
name to be canonical.

[ahe, 2013-12-17 11:07:57]

LGTM!

[zarah, 2013-12-17 12:49:40]

LGTM.

[rmacnak, 2013-12-17 18:30:33]

Committed patchset #4 manually as r31200 (presubmit successful).