Issue 1036723002: Move "null2" getter from ConstantVisitor to TypeProvider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1036723002: Move "null2" getter from ConstantVisitor to TypeProvider. (Closed)

Created:
5 years, 9 months ago by Paul Berry

Modified:
5 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Move "null2" getter from ConstantVisitor to TypeProvider. ConstantVisitor isn't a very long-lived object, and it's going to get even shorter-lived in the new task model, so the caching is ineffective. Moving the getter to the TypeProvider makes it easier to get to and improves caching. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=44684

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -20 lines)			Patch
M	pkg/analyzer/lib/src/generated/constant.dart	View	6 chunks	+4 lines, -20 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	3 chunks	+18 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/testing/test_type_provider.dart	View	3 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

5 years, 9 months ago (2015-03-25 15:33:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44684 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages