Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1036343003: Fix off-by-one bug in many_files_test. (Closed)

Created:
5 years, 9 months ago by Bob Nystrom
Modified:
5 years, 9 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix off-by-one bug in many_files_test. BUG=22996 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=44761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M sdk/lib/_internal/pub/pub.status View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/lish/many_files_test.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
5 years, 9 months ago (2015-03-27 18:17:27 UTC) #2
nweiz
lgtm Oh, *Windows*. http://media0.giphy.com/media/uiVH8ETzr9nZm/giphy.gif
5 years, 9 months ago (2015-03-27 20:00:54 UTC) #3
Bob Nystrom
5 years, 9 months ago (2015-03-27 20:11:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44761 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698