Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1036263002: Change type annotation buildInvokeConstructorInvocation. (Closed)

Created:
5 years, 8 months ago by karlklose
Modified:
5 years, 8 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Change type annotation buildInvokeConstructorInvocation. The Dart backend uses the type directly to reconstruct malformed constructor calls and the JavaScript backend will generate code to throw an exception when encountering an ErroneousElement as target. R=asgerf@google.com Committed: https://code.google.com/p/dart/source/detail?r=44735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 8 months ago (2015-03-27 14:03:44 UTC) #1
asgerf
lgtm
5 years, 8 months ago (2015-03-27 14:10:02 UTC) #2
karlklose
5 years, 8 months ago (2015-03-27 14:11:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44735 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698