Fix instruction removal for 'as' test; the bug caused us to stop optimizing after an 'as' test.

Fix instruction removal for 'as' test; the bug caused us to stop optimizing after an 'as' test.

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31395

[zra, 2013-12-27 21:10:05]

lgtm with questions.

https://codereview.chromium.org/103553006/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/103553006/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:3427:
current_iterator()->RemoveCurrentFromGraph();
Many other uses of RemoveCurrentFromGraph() are preceded by an ASSERT checking
that the correct node will be removed from the graph. Would it make sense to do
something like that here, too? Would it make sense to ASSERT before
RemoveFromGraph(), as well, since removing the wrong node caused the problem
here?

[srdjan, 2013-12-27 21:35:00]

https://codereview.chromium.org/103553006/diff/1/runtime/vm/flow_graph_optimi...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/103553006/diff/1/runtime/vm/flow_graph_optimi...
runtime/vm/flow_graph_optimizer.cc:3427:
current_iterator()->RemoveCurrentFromGraph();
On 2013/12/27 21:10:06, zra wrote:
> Many other uses of RemoveCurrentFromGraph() are preceded by an ASSERT checking
> that the correct node will be removed from the graph. Would it make sense to
do
> something like that here, too? Would it make sense to ASSERT before
> RemoveFromGraph(), as well, since removing the wrong node caused the problem
> here?

Good point, added the assert.

[srdjan, 2013-12-27 21:36:29]

Committed patchset #2 manually as r31395 (presubmit successful).